Skip to content

Suppress C4866 in PayloadDecoder and JsonFormatter's usage of json.hpp #1324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lalitb merged 1 commit into from
Feb 3, 2025
Merged

Suppress C4866 in PayloadDecoder and JsonFormatter's usage of json.hpp #1324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions lib/decoder/PayloadDecoder.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,12 @@ namespace clienttelemetry {
return true;
}

#ifdef _MSC_VER
#pragma warning(push)
#pragma warning(disable : 4866)
// In C++17 left-to-right evaluation order for operands of operator[] is not guaranteed when the argument's copy constructor is run.
// Evalutation order isn't not relied upon here, disabling warning.
#endif // _MSC_VER
void to_json(json& j, const Data& d)
{
for (const auto &kv : d.properties)
Expand Down Expand Up @@ -230,6 +236,9 @@ namespace clienttelemetry {
}
}
}
#ifdef _MSC_VER
#pragma warning( pop )
#endif // _MSC_VER

void to_json(json& j, const Record& r)
{
Expand Down
9 changes: 9 additions & 0 deletions lib/system/JsonFormatter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,12 @@ namespace MAT_NS_BEGIN
}
}

#ifdef _MSC_VER
#pragma warning( push )
#pragma warning( disable : 4866 )
// In C++17 left-to-right evaluation order for operands of operator[] is not guaranteed when the argument's copy constructor is run.
// Evalutation order isn't not relied upon here, disabling warning.
#endif // _MSC_VER
void addData(json& object, std::vector<::CsProtocol::Data>& data)
{
std::vector<::CsProtocol::Data>::const_iterator it;
Expand Down Expand Up @@ -126,6 +132,9 @@ namespace MAT_NS_BEGIN
}
}
}
#ifdef _MSC_VER
#pragma warning( pop )
#endif // _MSC_VER

std::string JsonFormatter::getJsonFormattedEvent(IncomingEventContextPtr const& event)
{
Expand Down
Loading