fix sanitizer android #1374
Merged
fix sanitizer android #1374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes Android build issues for the sanitizer component by addressing path configuration, variable naming corrections, and module references.
- Updates submodule reference to fix Android build compatibility
- Corrects variable naming from
configtosanitizerConfigand fixes deprecated reference fromspDataInspectortospSanitizer - Adds missing include paths for sanitizer modules in Android CMake configuration
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lib/modules | Updates submodule commit reference |
| lib/jni/Sanitizer_jni.cpp | Fixes variable naming and removes unused include |
| lib/jni/SanitizerHelper.hpp | Renames struct from Sanitizer to SanitizerHelper |
| lib/android_build/maesdk/src/main/cpp/CMakeLists.txt | Adds sanitizer module include paths |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Tested in mac. It works now. |
anod
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add path to modules for android build
fix config
fix spDataInspector renamed to spSanitizer