added additional config properties #1377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 9, 2025 07:55
nishchith-cp
reviewed
Sep 9, 2025
nishchith-cp
approved these changes
Sep 9, 2025
lalitb
approved these changes
Sep 9, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds support for warning mode configuration to iOS and Android sanitizer implementations, allowing control over whether sanitization warnings are enforced or suppressed.
- Added
setWarningsToSanitization/warningsOffproperties to sanitizer configuration classes - Updated native initialization methods to accept the new warning configuration parameter
- Enhanced Java configuration class with proper encapsulation and getter/setter methods
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| SanitizerInitConfig.swift | Added setWarningsToSanitization property wrapper for iOS |
| Sanitizer.swift | Fixed method name from resetPrivacyGuardInstance to resetSanitizerInstance |
| ODWSanitizerInitConfig.mm | Added initializer with default values for new properties |
| ODWSanitizerInitConfig.h | Added setWarningsToSanitization property declaration and initializer |
| ODWSanitizer.mm | Updated initialization to configure warning behavior |
| Sanitizer_jni.cpp | Modified JNI method to accept warnings parameter |
| SanitizerConfiguration.java | Refactored with private fields, getters/setters, and added warningsOff property |
| Sanitizer.java | Updated to use new configuration methods and pass warnings parameter |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...oid_build/maesdk/src/main/java/com/microsoft/applications/events/SanitizerConfiguration.java
Outdated
Show resolved
Hide resolved
ThomsonTan
approved these changes
Sep 10, 2025
Contributor
Author
|
Need to add JNI for logmanager |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added support for warning mode for iOS and Android.