Including payload decoder into CMakeList.txt for the library #1382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lalitb
approved these changes
Sep 16, 2025
Contributor
lalitb
left a comment
lalitb
left a comment
There was a problem hiding this comment.
@ThomsonTan - Probably we need force merge as CI failure is unrelated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
PayloadDecoder.hppis a public interface, if people try to use it they will face a linker error because that symbol is not compiled in the library so therefore not included in final binary.So this PR adds it to CMakeList.txt to ensure payload decoder is compiled and included in the final library binary and we are able to compile and link successfully.
Fixes #1381