Skip to content

Remove implicit hstring constructor for string_view #1529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
justanotheranonymoususer wants to merge 3 commits into
base: master
Choose a base branch
from
+3 −8
Open

Remove implicit hstring constructor for string_view #1529

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7d7b827
Remove implicit hstring constructor for string_view
justanotheranonymoususer Jan 7, 2026
8dc471a
Delete ptr+size constructor
justanotheranonymoususer Jan 8, 2026
af9103d
Try to fix
justanotheranonymoususer Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions cppwinrt/component_writers.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,9 +149,9 @@ bool __stdcall %_can_unload_now() noexcept
return true;
}

void* __stdcall %_get_activation_factory([[maybe_unused]] std::wstring_view const& name)
void* __stdcall %_get_activation_factory([[maybe_unused]] winrt::hstring const& name)
{
auto requal = [](std::wstring_view const& left, std::wstring_view const& right) noexcept
auto requal = [](winrt::hstring const& left, winrt::hstring const& right) noexcept
{
return std::equal(left.rbegin(), left.rend(), right.rbegin(), right.rend());
};
Expand Down Expand Up @@ -189,7 +189,7 @@ int32_t __stdcall WINRT_CanUnloadNow() noexcept

int32_t __stdcall WINRT_GetActivationFactory(void* classId, void** factory) noexcept try
{
std::wstring_view const name{ *reinterpret_cast<winrt::hstring*>(&classId) };
winrt::hstring& const name{ *reinterpret_cast<winrt::hstring*>(&classId) };
*factory = %_get_activation_factory(name);

if (*factory)
Expand Down
5 changes: 0 additions & 5 deletions strings/base_string_input.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,6 @@ WINRT_EXPORT namespace winrt::param
{
}

hstring(std::wstring_view const& value) noexcept
Copy link
Member

@DefaultRyan DefaultRyan Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is too much of a breaking source change to take at this point. I'd suggest adding it to the list of v3 features under consideration on #1123

{
create_string_reference(value.data(), value.size());
}

hstring(std::wstring const& value) noexcept
{
create_string_reference(value.data(), value.size());
Expand Down