docs: Psl doc input #657
docs: Psl doc input #657
Conversation
chore: merge dev into main
fix: removed SecurityControl
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
chore: Merge Dev to Main
…ate logging messages
ci: Integrated Smoke Testing Automation
chore: merging dev changes to main
Added authentication step for Azure in VS Code Web.
Thanusree-Microsoft
requested review from
Avijit-Microsoft,
Prajwal-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft,
aniaroramsft,
dgp10801,
malrose07,
nchandhi and
toherman-msft
as code owners
There was a problem hiding this comment.
Pull request overview
This PR updates the Deployment Guide documentation to add Azure authentication instructions for VS Code Web environment and includes extensive test automation infrastructure improvements. The changes include a new comprehensive test file with 4,225 lines covering 25+ test scenarios, enhanced test reporting with screenshot capture, and optimized CI/CD workflows.
Key Changes:
- Added "Authenticate with Azure" step in deployment documentation for VS Code Web
- Replaced test_gp_docgen.py with comprehensive test_st_docgen_tc.py containing 25+ test cases
- Enhanced test reporting with automatic screenshot capture on failures
- Optimized page object methods with reduced wait times
- Updated CI/CD workflows with better conditional logic and notification messages
Reviewed changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/DeploymentGuide.md | Added Azure device code authentication step for VS Code Web deployment |
| README.md | Updated VS Code Web badge URL from insiders.vscode.dev to vscode.dev |
| tests/e2e-test/tests/test_st_docgen_tc.py | New comprehensive test file with 25+ end-to-end test scenarios (4,225 lines) |
| tests/e2e-test/tests/test_gp_docgen.py | Removed old golden path test file (replaced by new comprehensive tests) |
| tests/e2e-test/tests/conftest.py | Enhanced with screenshot capture on test failures and improved reporting |
| tests/e2e-test/pages/*.py | Updated page objects with optimized wait times and new helper methods |
| tests/e2e-test/config/constants.py | Added new test data constants for browse and generate questions |
| .github/workflows/*.yml | Updated workflows with better conditionals and notification messages |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| # Select 3 sections to remove from the initial list | ||
| sections_to_remove = [] | ||
| if initial_count >= 3: |
There was a problem hiding this comment.
Test is always true, because of this condition.
| with check: | ||
| assert thread_count > 0, "No chat history threads found to hover over" | ||
|
|
||
| if thread_count > 0: |
There was a problem hiding this comment.
Test is always true, because of this condition.
| assert current_responses_empty == initial_responses, \ | ||
| f"BUG: System accepted empty query. Response count changed from {initial_responses} to {current_responses_empty}" | ||
|
|
||
| if current_responses_empty == initial_responses: |
There was a problem hiding this comment.
Test is always true, because of this condition.
|
|
||
| page = login_logout | ||
| home_page = HomePage(page) | ||
| browse_page = BrowsePage(page) |
There was a problem hiding this comment.
Variable browse_page is not used.
| browse_page = BrowsePage(page) |
| start = time.time() | ||
|
|
There was a problem hiding this comment.
Variable start is not used.
| start = time.time() | |
| try: | ||
| threads.first.wait_for(state="visible", timeout=10000) | ||
| logger.info("✅ Chat history created and displayed with %d thread(s)", threads.count()) | ||
| except: |
There was a problem hiding this comment.
Except block directly handles BaseException.
| except: | |
| except Exception: |
| try: | ||
| delete_icon.wait_for(state="visible", timeout=2000) | ||
| is_delete_visible = True | ||
| except: |
There was a problem hiding this comment.
Except block directly handles BaseException.
| try: | ||
| edit_icon.wait_for(state="visible", timeout=2000) | ||
| is_edit_visible = True | ||
| except: |
There was a problem hiding this comment.
Except block directly handles BaseException.
| page.keyboard.press("Escape") | ||
| page.wait_for_timeout(1000) | ||
| logger.info("Closed chat history using Escape key") | ||
| except: |
There was a problem hiding this comment.
Except block directly handles BaseException.
| except: | |
| except Exception: |
| logger.info("✅ Tooltip displayed successfully on chat history hover") | ||
| logger.info("Tooltip text length: %d characters", len(tooltip_text)) | ||
| else: | ||
| logger.error("❌ BUG FOUND: No tooltip displayed when hovering over chat history") |
There was a problem hiding this comment.
This statement is unreachable.
Added instructions for using Visual Studio Code Web in the deployment guide.
Purpose
Updated Deployment Guide
Does this introduce a breaking change?
Other Information
Added "Authenticate with Azure" point