ci: fixed Pipeline failures #663
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request introduces robust input validation steps to both the Linux and Windows deployment workflows, ensuring that all workflow input parameters are checked for correctness before proceeding with deployments. Additionally, it improves the reliability and correctness of Azure resource ID validations and enhances deployment job conditions.
Key changes:
Input validation improvements:
validate-inputsjob to both.github/workflows/deploy-linux.ymland.github/workflows/deploy-windows.ymlthat checks all workflow input parameters for validity (such as Azure region, resource group name, booleans, and Azure Resource ID formats) before running the main deployment workflow. The deployment now only proceeds if validation passes, and all subsequent jobs use the validated outputs. [1] [2]Azure Resource ID validation enhancements:
.github/workflows/job-deploy-linux.ymlto allow for case-insensitive matching of Azure resource types (e.g.,resourceGroups,Microsoft.OperationalInsights,Microsoft.MachineLearningServices, etc.), making the validation more robust and less error-prone. [1] [2]Deployment workflow logic:
.github/workflows/deploy-orchestrator.ymlto ensure deployment only runs if the Docker build succeeded or was skipped, in addition to the existing conditions.Parameter propagation:
validate-inputsjob, ensuring that only validated values are used in downstream steps. [1] [2]Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information