Skip to content

fix(Table): use distinct hover background color #35588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mainframev wants to merge 3 commits into
base: master
Choose a base branch
from
+14 −6
Open

fix(Table): use distinct hover background color #35588

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9907286
fix(Table): appearance neutral background hover
mainframev Dec 18, 2025
8c559a7
chore: change files
mainframev Dec 18, 2025
b53a566
test(vr-tests): add brand and neutral variants for cell actions story
mainframev Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion apps/vr-tests-react-components/src/stories/Table/TableCellActions.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import { CellActionsAlwaysVisible, CellActionsDefault, CellActionsInHeaderCell }

export default {
title: 'Table layout table - cell actions',

decorators: [],
parameters: {
storyWright: { steps: new Steps().hover('.row-1').snapshot('hover row').end() },
Expand All @@ -18,6 +17,10 @@ export default {
export const Default = () => <CellActionsDefault noNativeElements={false} />;
Default.storyName = 'default';

export const Neutral = () => <CellActionsDefault selectedRowAppearance="neutral" noNativeElements={false} />;

export const Brand = () => <CellActionsDefault selectedRowAppearance="brand" noNativeElements={false} />;

export const DefaultRTL = getStoryVariant(Default, RTL);

export const DefaultHighContrast = getStoryVariant(Default, HIGH_CONTRAST);
Expand Down
4 changes: 2 additions & 2 deletions apps/vr-tests-react-components/src/stories/Table/utils.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ interface SharedVrTestArgs {
selectedRowAppearance?: TableRowProps['appearance'];
}

export const CellActionsDefault: React.FC<SharedVrTestArgs> = ({ noNativeElements }) => (
export const CellActionsDefault: React.FC<SharedVrTestArgs> = ({ noNativeElements, selectedRowAppearance }) => (
<Table noNativeElements={noNativeElements}>
<TableHeader>
<TableRow>
Expand All @@ -139,7 +139,7 @@ export const CellActionsDefault: React.FC<SharedVrTestArgs> = ({ noNativeElement
</TableHeader>
<TableBody>
{items.map((item, i) => (
<TableRow key={item.file.label} className={`row-${i}`}>
<TableRow key={item.file.label} className={`row-${i}`} appearance={selectedRowAppearance}>
<TableCell>
<TableCellLayout media={item.file.icon}>
{item.file.label}
Expand Down
7 changes: 7 additions & 0 deletions change/@fluentui-react-table-88b119b2-0ee8-457c-8e60-3b36a6f5dff1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "fix: use distinct hover background color",
"packageName": "@fluentui/react-table",
"email": "vgenaev@gmail.com",
"dependentChangeType": "patch"
}
4 changes: 1 addition & 3 deletions .../react-components/react-table/library/src/components/TableRow/useTableRowStyles.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,9 +125,7 @@ const useStyles = makeStyles({
},
backgroundColor: tokens.colorSubtleBackgroundSelected,
color: tokens.colorNeutralForeground1Hover,
':hover': {
backgroundColor: tokens.colorSubtleBackgroundSelected,
},

':active': {
backgroundColor: tokens.colorSubtleBackgroundSelected,
},
Expand Down