chore: migrate to eslint flat configs #35590
Conversation
mainframev
changed the title
📊 Bundle size report✅ No changes found |
|
Pull request demo site: URL |
mainframev
requested review from
a team,
JustSlone,
jurokapsiar and
tudorpopams
as code owners
| @@ -0,0 +1,7 @@ | |||
| { | |||
| "type": "none", | |||
| "comment": "chore: update verify-packaging script to exclude root eslintrc file", | |||
There was a problem hiding this comment.
this shouldn't exists, we need to update beachball ignore definition to:
"**/.eslintrc.*",
+"**/eslint.config.*",https://github.com/microsoft/fluentui/blob/master/scripts/beachball/base.config.json#L9
| "{workspaceRoot}/.eslintrc.json", | ||
| "{workspaceRoot}/.eslintignore", | ||
| "{workspaceRoot}/eslint.config.js", | ||
| "{workspaceRoot}/eslint.config.cjs", |
There was a problem hiding this comment.
we can merge these two into {workspaceRoot}/eslint.config.[mc]js" or covering all 3 extensions {workspaceRoot}/jest.config.{cjs,mjs,js}
There was a problem hiding this comment.
you are removing the root eslint config file. we wanted to follow standard nx practices like we have in contrib for eg - having repo root eslint which is being spread per project flat configs (https://github.com/microsoft/fluentui-contrib/blob/main/eslint.config.js) with the exception of v8 packages that will be kept as is because I don't think we can make the separation of rules applied work simply by file matching globs.
2 participants
Removes the rest of legacy eslint configs, updates configuration files, scripts, ensures tooling and ownership files reflect the new structure.
Related Issue(s)