Skip to content

Conversation

@dlevy-msft-sql
Copy link
Contributor

@dlevy-msft-sql dlevy-msft-sql commented Jan 29, 2026

Summary

Upgrades github.com/docker/distribution from v2.8.2 to v2.8.3 and fixes the breaking change by migrating to the new standalone reference package.

Problem

PR #658 (Dependabot) attempted to upgrade docker/distribution but failed with:

github.com/docker/distribution@v2.8.3+incompatible/reference/reference_deprecated.go:122:19: 
undefined: reference.SplitHostname

The v2.8.3 release deprecated the reference package and moved it to github.com/distribution/reference as a standalone module.

Changes

  • Upgrades github.com/docker/distribution from v2.8.2 to v2.8.3
  • Adds github.com/distribution/reference v0.6.0 (the new standalone package)
  • Updates internal/container/docker.go to import from the new package location

Testing

  • go build ./... passes
  • TestController_ListTags passes (uses the reference package)

Supersedes #658

…on/reference

The docker/distribution v2.8.3 release deprecated the reference package
and moved it to github.com/distribution/reference as a standalone module.

This change:
- Upgrades github.com/docker/distribution from v2.8.2 to v2.8.3
- Migrates import from github.com/docker/distribution/reference to
  github.com/distribution/reference (v0.6.0)

This supersedes #658 which failed to build due to the breaking change.

Closes #658
@dlevy-msft-sql dlevy-msft-sql self-assigned this Jan 29, 2026
@dlevy-msft-sql dlevy-msft-sql added dependencies Pull requests that update a dependency file Size: S Small issue (less than one week effort) labels Jan 29, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR upgrades github.com/docker/distribution from v2.8.2 to v2.8.3 and addresses a breaking change introduced in the newer version. The v2.8.3 release deprecated the reference package within docker/distribution and moved it to a standalone module at github.com/distribution/reference. This PR correctly migrates the codebase to use the new standalone reference package.

Changes:

  • Upgrades docker/distribution dependency from v2.8.2 to v2.8.3 in go.mod
  • Adds the new standalone github.com/distribution/reference v0.6.0 as a direct dependency (moved from indirect)
  • Updates the import statement in internal/container/docker.go to use the new package location

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
go.mod Updates docker/distribution to v2.8.3 and adds distribution/reference v0.6.0 as a direct dependency
go.sum Updates checksums for the upgraded docker/distribution v2.8.3 package
internal/container/docker.go Migrates import from deprecated docker/distribution/reference to new standalone distribution/reference package

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated no new comments.

@dlevy-msft-sql dlevy-msft-sql merged commit 460b0c9 into main Jan 29, 2026
14 checks passed
@dlevy-msft-sql dlevy-msft-sql deleted the fix/docker-distribution-283 branch January 29, 2026 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file Size: S Small issue (less than one week effort)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants