Fix: Replace manual placeholders to avoid .format() issues in COMMUNITY_REPORT_PROMPT#1901
Open
droideronline wants to merge 1 commit intomicrosoft:mainfrom
Open
Fix: Replace manual placeholders to avoid .format() issues in COMMUNITY_REPORT_PROMPT#1901droideronline wants to merge 1 commit intomicrosoft:mainfrom
droideronline wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Author
|
@AlonsoGuevara Please review the PR when you have time. Thanks! |
Collaborator
|
Did you run prompt tuning? It looks like the issue is that prompt tune calls format to insert its variables, reducing the bracket count by one when written back out. Running with default prompts does not exhibit the issue. We're going to look for a fix on the prompt tuning side so we can retain the use of |
Author
|
Yes, I did manual prompt tuning, understood now it makes sense. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
community_reports_extractorfile Using .format() caused errors because the COMMUNITY_REPORT_PROMPT has other{}braces (e.g., in JSON examples).Related Issues
#1900
Proposed Changes
{input_text}and{max_report_length}.Checklist
Additional Notes