Log final LCOW OCI spec; always call go in Makefile #2570
Merged
+82
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use an `io.MultiWriter` to capture the OCI spec as written to the `config.json` file that is provided to runc so it can be logged, and avoid needing to marshal the spec twice. Also, add a `FORCE` target to the Makefile to always run the `go build` recipe for Go binaries. This fixes a bug where make will not rebuild the binaries and instead `make clean` must be called to remove them before building. See: www.gnu.org/software/make/manual/html_node/Force-Targets.html Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
anmaxvl
reviewed
Dec 3, 2025
Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
anmaxvl
approved these changes
Dec 4, 2025
jiechen0826
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use an
io.MultiWriterto capture the OCI spec as written to theconfig.jsonfile that is provided to runc so it can be logged, and avoid needing to marshal the spec twice.Also, add a
FORCEtarget to the Makefile to always run thego buildrecipe for Go binaries.This fixes a bug where make will not rebuild the binaries and instead
make cleanmust be called to remove them before building.See: www.gnu.org/software/make/manual/html_node/Force-Targets.html