Skip to content

Fix deserialization of List<Double> in JSON parse node #2025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
baywet merged 2 commits into from
Sep 8, 2025
Merged

Fix deserialization of List<Double> in JSON parse node #2025

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
300c3af
Add a test case to validate ability to deserialize collections of Dou…
jamie-heller Sep 4, 2025
3088448
Add branch for java.lang.Double to getPrimitiveValue
jamie-heller Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...nts/serialization/json/src/main/java/com/microsoft/kiota/serialization/JsonParseNode.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,8 @@ public JsonParseNode(@Nonnull final JsonElement node) {
return (T) itemNode.getIntegerValue();
} else if (targetClass == Float.class) {
return (T) itemNode.getFloatValue();
} else if (targetClass == Double.class) {
return (T) itemNode.getDoubleValue();
} else if (targetClass == Long.class) {
return (T) itemNode.getLongValue();
} else if (targetClass == UUID.class) {
Expand Down
15 changes: 15 additions & 0 deletions ...erialization/json/src/test/java/com/microsoft/kiota/serialization/JsonParseNodeTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,4 +172,19 @@ void GetEntityWithUntypedNodesFromJson() throws UnsupportedEncodingException {
}
}
}

@Test
void getCollectionOfPrimitiveDoubleValues() throws UnsupportedEncodingException {
final var initialString = "{\"values\":[1.1,2.2,3.3]}";
final var rawResponse = new ByteArrayInputStream(initialString.getBytes("UTF-8"));
final var parseNode = _parseNodeFactory.getParseNode(contentType, rawResponse);
final var valuesNode = parseNode.getChildNode("values");
assertNotNull(valuesNode);
final var doubles = valuesNode.getCollectionOfPrimitiveValues(Double.class);
assertNotNull(doubles);
assertEquals(3, doubles.size());
assertEquals(1.1, doubles.get(0), 0.000001);
assertEquals(2.2, doubles.get(1), 0.000001);
assertEquals(3.3, doubles.get(2), 0.000001);
}
}