FEAT: Expand CI Testing to add new SQL Server Versions#308
Merged
bewithgaurav merged 10 commits intomainfrom Nov 3, 2025
Merged
FEAT: Expand CI Testing to add new SQL Server Versions#308bewithgaurav merged 10 commits intomainfrom
bewithgaurav merged 10 commits intomainfrom
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the CI/CD pipeline to expand SQL Server version coverage and introduce matrix-based testing. The changes add support for testing against multiple SQL Server versions including LocalDB, SQL Server 2022, SQL Server 2025, and Azure SQL Database.
Key Changes
- Added matrix strategy for Windows testing to run tests against both LocalDB and SQL Server 2022
- Introduced SQL Server 2025 preview testing for Linux environments
- Enhanced test result aggregation with version-specific naming for better traceability
Comments suppressed due to low confidence (2)
eng/pipelines/pr-validation-pipeline.yml:363
- The condition only checks for 'Ubuntu' but now there are two Ubuntu matrix entries: 'Ubuntu' and 'Ubuntu-SQL2025'. The 'Ubuntu-SQL2025' entry will fall into the 'else' branch and be treated as Debian, which is incorrect. Update the condition to handle both Ubuntu variants, for example:
if [[ "$(distroName)" == Ubuntu* ]]; then
if [ "$(distroName)" = "Ubuntu" ]; then
eng/pipelines/pr-validation-pipeline.yml:389
- Similar to the previous issue, this condition only matches 'Ubuntu' exactly and will not match 'Ubuntu-SQL2025'. The Ubuntu-SQL2025 matrix entry will incorrectly use the Debian package configuration. Update to handle both Ubuntu variants:
if [[ '$(distroName)' == Ubuntu* ]]; then
if [ '$(distroName)' = 'Ubuntu' ]; then
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
📊 Code Coverage Report
Diff CoverageDiff: main...HEAD, staged and unstaged changesNo lines with coverage information in this diff. 📋 Files Needing Attention📉 Files with overall lowest coverage (click to expand)mssql_python.pybind.ddbc_bindings.cpp: 70.7%
mssql_python.row.py: 77.9%
mssql_python.ddbc_bindings.py: 79.6%
mssql_python.pybind.connection.connection.cpp: 81.2%
mssql_python.connection.py: 82.9%
mssql_python.cursor.py: 83.6%
mssql_python.pybind.connection.connection_pool.cpp: 84.8%
mssql_python.auth.py: 87.1%
mssql_python.pooling.py: 87.7%
mssql_python.exceptions.py: 92.1%🔗 Quick Links
|
saurabh500
reviewed
Oct 29, 2025
saurabh500
reviewed
Oct 29, 2025
bewithgaurav
changed the title
bewithgaurav
commented
Oct 30, 2025
bewithgaurav
commented
Oct 30, 2025
sumitmsft
approved these changes
Oct 30, 2025
jahnvi480
approved these changes
Oct 30, 2025
saurabh500
reviewed
Oct 30, 2025
saurabh500
approved these changes
Oct 30, 2025
Contributor
saurabh500
left a comment
saurabh500
left a comment
There was a problem hiding this comment.
Left a comment FYI. nothing to do. Make a note in any maintenance docs or perhaps add a comment in the script. 😃
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work Item / Issue Reference
Summary
This pull request updates the
pr-validation-pipeline.ymlto enhance test coverage and CI flexibility by adding matrix builds for multiple SQL Server environments (LocalDB, SQL Server 2022, and Azure SQL Database) on Windows, and by introducing support for SQL Server 2025 on Linux via Docker. The changes ensure that tests are run and results are published for each supported SQL backend, improving reliability and compatibility testing.Windows build matrix and test orchestration:
LocalDBandSQL Server 2022on Windows, allowing the pipeline to test against multiple SQL Server versions in parallel.Linux build matrix and SQL Server version support: