Remove timeouts and update details in comments #837
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 17, 2025
Closed
rzhao271
approved these changes
Dec 17, 2025
Tyriar
added a commit
to microsoft/vscode
that referenced
this pull request
Dec 19, 2025
Brings in further improvements to handling of write backpressure. After this we no longer throttle at all which means that for older versions of bash at least on macOS interleaving is possible, but pasting and sending should be near instantaneous for any reasonable amount of text. I measured zsh injesting 5mb of data in ~14 seconds. See: - microsoft/node-pty#835 - microsoft/node-pty#837 - microsoft/node-pty#839 Part of #246204, #283056
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #833
Merge first:
After this change, pasting 5mb(!) into the xterm.js demo takes 14 seconds, as opposed to 8 seconds for kitty and ghostty. We likely can't squeeze more perf out of it without removing the node overhead which isn't worth it considering the additional maintenance overhead and how well this performs already now.