-
Notifications
You must be signed in to change notification settings - Fork 5k
chore(html): add shard weight suggestion #38696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
||
| for (const [botName, tests] of Object.entries(bots)) { | ||
| const botShards = shardsInfo.filter(shard => shard.tag.join(';') === botName); | ||
| const totalShard = Math.max(...botShards.map(s => s.shardIndex ?? -1)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if this code lived on the client side, we could make totalShard a UI control and the user could see optimal weights for different numbers of shards
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
docs/src/test-sharding-js.md
Outdated
|
|
||
| ```bash | ||
| npx playwright test --shard=1/4 --shard-weights=26:24:25:25 | ||
| npx playwright test --shard=x/4 --shard-weights=30:20:25:25 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will be less confusing, if example weights do not sum up to 100. Otherwise, one may get a false impression that's required.
Test results for "MCP"3 failed 2819 passed, 116 skipped Merge workflow run. |
Test results for "tests 1"6 failed 1 flaky34409 passed, 696 skipped Merge workflow run. |
No description provided.