[0.81-stable] Minor future-proofing changes#2827
Open
amgleitman wants to merge 1 commit intomicrosoft:0.81-stablefrom
Open
[0.81-stable] Minor future-proofing changes#2827amgleitman wants to merge 1 commit intomicrosoft:0.81-stablefrom
amgleitman wants to merge 1 commit intomicrosoft:0.81-stablefrom
Conversation
amgleitman
changed the title
Saadnajmi
approved these changes
Feb 4, 2026
| #pragma once | ||
|
|
||
| #include <react/renderer/graphics/Geometry.h> | ||
| #include <react/renderer/graphics/Float.h> // [macOS] |
| // Unspecified values do not. | ||
| // This wouldn't override a container view's `userInteractionEnabled = NO` | ||
| view.userInteractionEnabled = YES; | ||
| break; // [macOS] |
Collaborator
There was a problem hiding this comment.
Can we also make this upstream in main?
Collaborator
There was a problem hiding this comment.
Along with, a bunch of the changes here
|
|
||
| // Atomic variant of `_waitingForMountingStageOnMainQueue = YES;` | ||
| atomic_fetch_or(&_waitingForMountingStageOnMainQueue, 1); | ||
| atomic_store(&_waitingForMountingStageOnMainQueue, 1); // [macOS] |
Collaborator
There was a problem hiding this comment.
Can we add a short comment why this had to change?
Collaborator
|
Nit, I added a PR title check, so the title should look something like: "fix(0.81): Let RNM build with c++23" (basically VERB(SCOPE): CHANGE) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
A couple of future-proofing changes to react-native-macos to suppress some warnings and ensure better C++23 compatibility.
Test Plan:
Validated that RNTester builds for macOS and iOS.