-
Notifications
You must be signed in to change notification settings - Fork 92
Development #677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Development #677
+695
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added custom_subdomain_name to OpenAI resource for managed identity authentication - Created Speech Service resource with custom subdomain configuration - Added RBAC role assignments for Speech Service (Managed Identity and App Service MI) - Includes Cognitive Services Speech User and Speech Contributor roles - Documentation: Azure Speech managed identity setup guide
Replaced REST API approach with SearchIndexClient SDK to properly handle managed identity authentication in Azure public cloud. The SDK automatically handles token acquisition and endpoint construction, eliminating the 'search_resource_manager is not defined' error that occurred with the REST API approach.
Replaced REST API approach with SearchIndexClient SDK to properly handle managed identity authentication in Azure public cloud. The SDK automatically handles token acquisition and endpoint construction, eliminating the 'search_resource_manager is not defined' error that occurred with the REST API approach.
…vche/simplechat-development into ai-search-test-connection-fix
Msft python image
* release note updating for github coplilot * fixed logo bug issue * added 2,3,4,5,6,14 days to rentention policy * added retention policy time updates
* Critical Retention Policy Deletion Fix * Create RETENTION_POLICY_NULL_LAST_ACTIVITY_FIX.md
Fix Azure AI Search Test Connection with Managed Identity
- Added explicit UTF-8 encoding when reading file content on Windows - Prevents UnicodeDecodeError when processing non-ASCII filenames - Ensures consistent file handling across different operating systems Co-authored-by: Chen, Vivien <Vivien.Chen+ecolab@ecolab.com>
Co-authored-by: vivche <vivche@microsoft.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…rm (#558) * Add custom subdomain support for OpenAI and Speech Service in Terraform - Added custom_subdomain_name to OpenAI resource for managed identity authentication - Created Speech Service resource with custom subdomain configuration - Added RBAC role assignments for Speech Service (Managed Identity and App Service MI) - Includes Cognitive Services Speech User and Speech Contributor roles - Documentation: Azure Speech managed identity setup guide * Update docs/how-to/azure_speech_managed_identity_manul_setup.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Chen, Vivien <Vivien.Chen+ecolab@ecolab.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update chat-sidebar-conversations.js * 0.237.006
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(v0.237.006)
Bug Fixes
Sidebar Conversations DOM Manipulation Fix
createSidebarConversationItem(), the code was attempting DOM manipulation in the wrong order. WhenoriginalTitleElementwas appended totitleWrapper, it was removed fromheaderRow, making the subsequentinsertBefore(titleWrapper, dropdownElement)fail becausedropdownElementwas no longer a valid child reference in the expected DOM position.originalTitleElementfrom DOM first, style it, add it totitleWrapper, then insert the completetitleWrapperbeforedropdownElement. Added validation to check ifdropdownElementis a valid child before attempting insertion.chat-sidebar-conversations.js,createSidebarConversationItem(), DOM manipulation order, line 150)Windows Unicode Encoding Issue Fix
UnicodeEncodeError: 'charmap' codec can't encode character '\uXXXX'when logging or displaying emojis, international characters, IPA symbols, or special formatting.sys.stdoutandsys.stderrto UTF-8 at the top ofapp.pybefore any imports or print statements. Includes fallback for older Python versions (<3.7). Platform-specific fix only applies on Windows.app.py, UTF-8 encoding configuration, cross-platform compatibility)Azure Speech Service Managed Identity Authentication Fix
https://eastus2.api.cognitive.microsoft.com) because the Bearer token doesn't specify which Speech resource to access. The regional gateway cannot determine resource authorization, resulting in 400 BadRequest errors. Key-based authentication works with regional endpoints because the subscription key identifies the specific resource.az cognitiveservices account update --custom-domain <resource-name>https://<resource-name>.cognitiveservices.azure.com(not regional endpoint)Cognitive Services Speech UserandCognitive Services Speech Contributorroles to App Service managed identityNameResolutionError(custom subdomain not enabled), 400 BadRequest (wrong endpoint type), 401 Authentication errors (missing RBAC roles).