Export diagnostic-collecting API for downstream emitter composition #9416
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The emitter was directly reporting diagnostics to the program, preventing downstream emitters from collecting and handling diagnostics according to TypeSpec best practices (
[Result, readonly Diagnostic[]]pattern).Changes
createModel()- Now returns[CodeModel, readonly Diagnostic[]]instead ofCodeModelcreateCodeModel()- New exported function wrapping emission logic, returns[void, readonly Diagnostic[]]Logger- Added diagnostic collection mode via constructor parameter andgetDiagnostics()method$onEmit()- Refactored to callcreateCodeModel()and report collected diagnosticsUsage
The Logger class now stores diagnostics when instantiated with
collectDiagnostics: true, enabling the pattern above while maintaining backward compatibility for normal emission.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.