Skip to content

code snippet provider #13018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lukka merged 3 commits into from
Feb 5, 2025
Merged

code snippet provider #13018

lukka merged 3 commits into from
Feb 5, 2025

Conversation

@lukka
Copy link
Member

@lukka lukka commented Dec 4, 2024

No description provided.

benmcmorran
benmcmorran reviewed Dec 5, 2024
View reviewed changes
sean-mcmanus
sean-mcmanus requested changes Dec 6, 2024
View reviewed changes
sean-mcmanus
sean-mcmanus reviewed Dec 6, 2024
View reviewed changes
@benmcmorran
Copy link
Member

benmcmorran commented Dec 6, 2024

@lukka Soon you should be able to take a dependency on https://www.npmjs.com/package/@github/copilot-language-server to get appropriate typings. The types aren't quite there yet, but https://github.com/github/copilot-client/pull/6250 is adding them.

@lukka lukka force-pushed the dev/lucappa/cop-ctx-api branch 2 times, most recently from 991df60 to 22235f3 Compare December 7, 2024 03:09
lukka
lukka commented Dec 7, 2024
View reviewed changes
lukka
lukka commented Dec 7, 2024
View reviewed changes
sean-mcmanus
sean-mcmanus previously requested changes Dec 9, 2024
View reviewed changes
sean-mcmanus
sean-mcmanus reviewed Dec 9, 2024
View reviewed changes
sean-mcmanus
sean-mcmanus reviewed Dec 9, 2024
View reviewed changes
@lukka lukka force-pushed the dev/lucappa/cop-ctx-api branch from 22235f3 to 0679bab Compare December 19, 2024 04:26
@sean-mcmanus sean-mcmanus self-requested a review December 20, 2024 20:09
@lukka lukka force-pushed the dev/lucappa/cop-ctx-api branch from 0679bab to b996200 Compare December 21, 2024 00:04
@lukka
Copy link
Member Author

lukka commented Dec 21, 2024

@lukka Soon you should be able to take a dependency on https://www.npmjs.com/package/@github/copilot-language-server to get appropriate typings. The types aren't quite there yet, but github/copilot-client#6250 is adding them.

This is done, thanks!

@lukka lukka force-pushed the dev/lucappa/cop-ctx-api branch 2 times, most recently from a7f8949 to d1876a2 Compare December 23, 2024 19:01
sean-mcmanus
sean-mcmanus reviewed Dec 23, 2024
View reviewed changes
@lukka lukka force-pushed the dev/lucappa/cop-ctx-api branch 4 times, most recently from 2919dcb to 391433a Compare January 9, 2025 00:41
@lukka lukka force-pushed the dev/lucappa/cop-ctx-api branch from 391433a to 9ee7b88 Compare January 13, 2025 20:14
@lukka lukka marked this pull request as ready for review January 13, 2025 20:14
@lukka lukka requested a review from a team as a code owner January 13, 2025 20:14
@lukka lukka force-pushed the dev/lucappa/cop-ctx-api branch from 9ee7b88 to 0c8d03d Compare January 16, 2025 04:05
sean-mcmanus
sean-mcmanus reviewed Jan 16, 2025
View reviewed changes
@lukka lukka force-pushed the dev/lucappa/cop-ctx-api branch from 0c8d03d to 5b63116 Compare January 22, 2025 01:08
@sean-mcmanus sean-mcmanus requested a review from a team January 22, 2025 20:53
@lukka lukka force-pushed the dev/lucappa/cop-ctx-api branch 2 times, most recently from dc61198 to 21f7254 Compare January 27, 2025 22:13
sean-mcmanus
sean-mcmanus previously approved these changes Jan 28, 2025
View reviewed changes
Colengms
Colengms reviewed Jan 28, 2025
View reviewed changes
@lukka lukka force-pushed the dev/lucappa/cop-ctx-api branch 2 times, most recently from 3f89017 to 02ec023 Compare January 28, 2025 07:11
sean-mcmanus
sean-mcmanus previously approved these changes Jan 29, 2025
View reviewed changes
Colengms
Colengms previously approved these changes Jan 29, 2025
View reviewed changes
@lukka lukka dismissed stale reviews from Colengms and sean-mcmanus via 1dc2fea February 4, 2025 07:48
@lukka lukka force-pushed the dev/lucappa/cop-ctx-api branch 3 times, most recently from 48530c5 to a46f929 Compare February 5, 2025 03:02
@lukka lukka force-pushed the dev/lucappa/cop-ctx-api branch from d1dd13c to 1f27e5b Compare February 5, 2025 21:43
benmcmorran
benmcmorran previously approved these changes Feb 5, 2025
View reviewed changes
kuchungmsft
kuchungmsft previously approved these changes Feb 5, 2025
View reviewed changes
Colengms
Colengms reviewed Feb 5, 2025
View reviewed changes
@lukka lukka dismissed stale reviews from kuchungmsft and benmcmorran via 91d0bcb February 5, 2025 22:21
@lukka lukka enabled auto-merge (squash) February 5, 2025 22:25
@lukka lukka merged commit 94758af into main Feb 5, 2025
6 checks passed
@lukka lukka deleted the dev/lucappa/cop-ctx-api branch February 5, 2025 22:26
@sean-mcmanus sean-mcmanus added this to the 1.24.0 milestone Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Colengms Colengms Colengms left review comments

@sean-mcmanus sean-mcmanus sean-mcmanus approved these changes

@benmcmorran benmcmorran benmcmorran left review comments

@kuchungmsft kuchungmsft kuchungmsft left review comments

Assignees

No one assigned

Labels

None yet

Projects

cpptools
Status: Done

Milestone

1.24.0

Development

Successfully merging this pull request may close these issues.

6 participants

@lukka @benmcmorran @sean-mcmanus @Colengms @kuchungmsft