Skip to content

Don't show the output window for "references may be missing" when the loggingLevel is less than Warning #13068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bobbrow merged 1 commit into from
Dec 18, 2024
Merged

Don't show the output window for "references may be missing" when the loggingLevel is less than Warning #13068

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions Extension/src/LanguageServer/references.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import * as telemetry from '../telemetry';
import { DefaultClient } from './client';
import { PersistentState } from './persistentState';
import { FindAllRefsView } from './referencesView';
import { CppSettings } from './settings';

nls.config({ messageFormat: nls.MessageFormat.bundle, bundleFormat: nls.BundleFormat.standalone })();
const localize: nls.LocalizeFunc = nls.loadMessageBundle();
Expand Down Expand Up @@ -469,19 +470,24 @@ export class ReferencesManager {
}

if (this.referencesStartedWhileTagParsing) {
const showLog: boolean = util.getNumericLoggingLevel(new CppSettings().loggingLevel) >= 3;
const msg: string = localize("some.references.may.be.missing", "[Warning] Some references may be missing, because workspace parsing was incomplete when {0} was started.",
referencesCommandModeToString(this.client.ReferencesCommandMode));
if (this.client.ReferencesCommandMode === ReferencesCommandMode.Peek) {
if (this.referencesChannel) {
this.referencesChannel.appendLine(msg);
this.referencesChannel.appendLine("");
this.referencesChannel.show(true);
if (showLog) {
this.referencesChannel.show(true);
}
}
} else if (this.client.ReferencesCommandMode === ReferencesCommandMode.Find) {
const logChannel: vscode.OutputChannel = logger.getOutputChannel();
logChannel.appendLine(msg);
logChannel.appendLine("");
logChannel.show(true);
if (showLog) {
logChannel.show(true);
}
}
}

Expand Down
Loading