Skip to content

Add reduceRecursiveIncludes setting #13306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Colengms wants to merge 3 commits into from
Closed

Add reduceRecursiveIncludes setting #13306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f603689
Add `reduceRecursiveIncludes` setting
Colengms Feb 22, 2025
f0ef0e2
Merge branch 'main' into coleng/reduceRecursiveIncludesSetting
Colengms Feb 22, 2025
bdcf0a4
Merge branch 'main' of https://github.com/microsoft/vscode-cpptools i…
Colengms Mar 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions Extension/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -973,6 +973,12 @@
]
},
"scope": "resource"
},
"C_Cpp.reduceRecursiveIncludes": {
"type": "boolean",
"default": true,
"markdownDescription": "%c_cpp.configuration.reduceRecursiveIncludes.markdownDescription%",
"scope": "window"
Copy link
Contributor

@sean-mcmanus sean-mcmanus Feb 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this have an enum like

                        "enum": [
                            "default",
                            "enabled",
                            "disabled"
                        ],

I'm not sure if "default" is needed (we could potentially use that to auto-set the default from an experiment).

Copy link
Contributor

@sean-mcmanus sean-mcmanus Feb 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh -- it's a bool -- your description references "enabled"/"disabled"? Should that be true/false instead?

}
}
},
Expand Down
1 change: 1 addition & 0 deletions Extension/package.nls.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -809,6 +809,7 @@
"Markdown text between `` should not be translated or localized (they represent literal text) and the capitalization, spacing, and punctuation (including the ``) should not be altered."
]
},
"c_cpp.configuration.reduceRecursiveIncludes.markdownDescription": "Indicates whether recursive include paths should be reduced to only those currently referenced by the translation unit. If enabled, performance is impacted if the database needs to be populated to determine headers used. If disabled, performance may be impacted due to passing a large number of include paths to the IntelliSense process.",
Copy link
Contributor

@sean-mcmanus sean-mcmanus Feb 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"enabled" and "disabled" should be in markdown/backticks like the other settings value examples.

Copy link
Contributor

@sean-mcmanus sean-mcmanus Feb 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or true/false as mentioned in the other thread.

"c_cpp.configuration.debugger.useBacktickCommandSubstitution.markdownDescription": {
"message": "If `true`, debugger shell command substitution will use obsolete backtick ``(`)``.",
"comment": [
Expand Down
1 change: 1 addition & 0 deletions Extension/src/LanguageServer/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1575,6 +1575,7 @@ export class DefaultClient implements Client {
enhancedColorization: workspaceSettings.isEnhancedColorizationEnabled,
intellisenseMaxCachedProcesses: workspaceSettings.intelliSenseMaxCachedProcesses,
intellisenseMaxMemory: workspaceSettings.intelliSenseMaxMemory,
reduceRecursiveIncludes: workspaceSettings.reduceRecursiveIncludes,
referencesMaxConcurrentThreads: workspaceSettings.referencesMaxConcurrentThreads,
referencesMaxCachedProcesses: workspaceSettings.referencesMaxCachedProcesses,
referencesMaxMemory: workspaceSettings.referencesMaxMemory,
Expand Down
2 changes: 2 additions & 0 deletions Extension/src/LanguageServer/settings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,7 @@ export interface SettingsParams {
enhancedColorization: boolean;
intellisenseMaxCachedProcesses: number | null;
intellisenseMaxMemory: number | null;
reduceRecursiveIncludes: boolean;
referencesMaxConcurrentThreads: number | null;
referencesMaxCachedProcesses: number | null;
referencesMaxMemory: number | null;
Expand Down Expand Up @@ -481,6 +482,7 @@ export class CppSettings extends Settings {
return super.Section.get<string>("cppCodeSnippetsFeatureNames");
}
public get formattingEngine(): string { return this.getAsString("formatting"); }
public get reduceRecursiveIncludes(): boolean { return this.getAsBoolean("reduceRecursiveIncludes"); }
public get vcFormatIndentBraces(): boolean { return this.getAsBoolean("vcFormat.indent.braces"); }
public get vcFormatIndentMultiLineRelativeTo(): string { return this.getAsString("vcFormat.indent.multiLineRelativeTo"); }
public get vcFormatIndentWithinParentheses(): string { return this.getAsString("vcFormat.indent.withinParentheses"); }
Expand Down