Skip to content

Stop skipping the top crash stack frames. #13403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sean-mcmanus merged 3 commits into from
Mar 24, 2025
Merged

Stop skipping the top crash stack frames. #13403

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
628db8a
Stop skipping the top crash stack frames.
sean-mcmanus Mar 22, 2025
6d72c2d
Merge branch 'main' into seanmcm/stopSkippingTopStackFrames
sean-mcmanus Mar 24, 2025
82435f3
Merge branch 'main' into seanmcm/stopSkippingTopStackFrames
Colengms Mar 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions Extension/src/LanguageServer/extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1213,14 +1213,11 @@ async function handleCrashFileRead(crashDirectory: string, crashFile: string, cr
data = telemetryHeader + signalType;
let crashCallStack: string = "";
let validFrameFound: boolean = false;
for (let lineNum: number = crashStackStartLine; lineNum < lines.length - 3; ++lineNum) { // skip last lines
for (let lineNum: number = crashStackStartLine + 1; lineNum < lines.length - 3; ++lineNum) { // skip last lines
const line: string = lines[lineNum];
const startPos: number = line.indexOf(startStr);
let pendingCallStack: string = "";
if (startPos === -1 || line[startPos + (isMac ? 1 : 4)] === "+") {
if (!validFrameFound) {
continue; // Skip extra … at the start.
}
pendingCallStack = dotStr;
const startAddressPos: number = line.indexOf("0x");
const endAddressPos: number = line.indexOf(endOffsetStr, startAddressPos + 2);
Expand Down