Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 12, 2025

The review actions dropdown (approve/comment/request changes) should always default to Comment as the primary action, appear first in both dropdown and expanded views, and only Comment should be blue when expanded to 3 buttons.

Changes

webviews/components/comment.tsx

  • Set currentSelection to always be ReviewType.Comment instead of deriving from last review type or user state
  • Reordered actions array: Comment → Approve → Request Changes
  • Pass primaryOptionValue={ReviewType.Comment} to ContextDropdown
  • Applied to both AddComment and AddCommentSimple components

webviews/components/contextDropdown.tsx

  • Added optional primaryOptionValue prop to identify the primary action
  • When expanded (width > 375px), apply secondary class to non-primary buttons
  • Primary button retains default blue styling; others use secondary styling

Behavior

Before: Primary action varied by history; order was Approve, Comment, Request Changes; all buttons styled identically when expanded

After: Primary action is always Comment; order is Comment, Approve, Request Changes; only Comment is blue when expanded

Original prompt

For the approve, comment, request changew dropdown button: make comment the primary action, make only the primary action blue when the dropdown has enough space to be 3 buttons, and make the primary action first, both when dropped down and when expanded.

User has selected text in file webviews/components/merge.tsx from 324:6 to 334:85

Created from VS Code via the GitHub Pull Request extension.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

…ng and styling

Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>
Copilot AI changed the title [WIP] Update dropdown button to prioritize comment action Make Comment the primary action in review dropdown Nov 12, 2025
Copilot AI requested a review from alexr00 November 12, 2025 13:59
@alexr00 alexr00 marked this pull request as ready for review November 13, 2025 13:13
@alexr00 alexr00 enabled auto-merge (squash) November 13, 2025 13:13
@vs-code-engineering vs-code-engineering bot added this to the November 2025 milestone Nov 13, 2025
@alexr00 alexr00 merged commit 8a8a4db into main Nov 13, 2025
6 checks passed
@alexr00 alexr00 deleted the copilot/update-dropdown-button-action branch November 13, 2025 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants