Skip to content

Fix dismiss notification functionality in PR view #8241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Fix dismiss notification functionality in PR view #8241

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0ede8d6
Initial plan
Copilot Dec 9, 2025
072bbf4
Initial plan for fixing notification refresh issue
Copilot Dec 9, 2025
359dbd2
Add notification change listeners to PRNode
Copilot Dec 9, 2025
0943d60
Complete PR - all checks passed
Copilot Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/@types/vscode.proposed.chatParticipantAdditions.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,7 @@ declare module 'vscode' {
isComplete?: boolean;
toolSpecificData?: ChatTerminalToolInvocationData;
fromSubAgent?: boolean;
presentation?: 'hidden' | 'hiddenAfterComplete' | undefined;

constructor(toolName: string, toolCallId: string, isError?: boolean);
}
Expand Down
32 changes: 32 additions & 0 deletions src/view/treeNodes/pullRequestNode.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ export class PRNode extends TreeNode implements vscode.CommentingRangeProvider2
super(parent);
this.registerSinceReviewChange();
this.registerConfigurationChange();
this.registerNotificationChanges();
this._register(this._folderReposManager.onDidChangeActivePullRequest(e => {
if (e.new?.number === this.pullRequestModel.number || e.old?.number === this.pullRequestModel.number) {
this.refresh(this);
Expand Down Expand Up @@ -144,6 +145,37 @@ export class PRNode extends TreeNode implements vscode.CommentingRangeProvider2
}));
}

protected registerNotificationChanges() {
// Listen for regular notification changes
this._register(this._notificationProvider.onDidChangeNotifications(notifications => {
// Check if any of the changed notifications are for this PR
const affectsThisPR = notifications.some(notification => {
if (notification.model instanceof PullRequestModel) {
return notification.model.number === this.pullRequestModel.number &&
notification.model.remote.owner === this.pullRequestModel.remote.owner &&
notification.model.remote.repositoryName === this.pullRequestModel.remote.repositoryName;
}
return false;
});
if (affectsThisPR) {
this.refresh(this);
}
}));

// Listen for Copilot notification changes
this._register(this._prsTreeModel.onDidChangeCopilotNotifications(pullRequests => {
// Check if any of the changed notifications are for this PR
const affectsThisPR = pullRequests.some(pr =>
pr.number === this.pullRequestModel.number &&
pr.remote.owner === this.pullRequestModel.remote.owner &&
pr.remote.repositoryName === this.pullRequestModel.remote.repositoryName
);
if (affectsThisPR) {
this.refresh(this);
}
}));
}

public async reopenNewPrDiffs(pullRequest: PullRequestModel) {
let hasOpenDiff: boolean = false;
vscode.window.tabGroups.all.map(tabGroup => {
Expand Down