Fix incorrect log message referring to conda environment in venv validation #789
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
findVirtualEnvironmentsfunction insrc/managers/builtin/venvUtils.tswas incorrectly logging "Invalid conda environment" when encountering invalid venv environments.Issue
When the function processes venv environments and encounters one with missing required properties (prefix, executable, or version), it logs an error message that incorrectly references "conda environment" instead of "venv environment".
Root Cause
The function specifically filters for venv environments using:
But the error logging was copy-pasted from conda-related code and never updated:
Fix
Updated the log message to correctly reference the environment type being processed:
This change ensures consistency with the function's purpose and with the success log message which already correctly states "Found venv environment".
Verification
Created from VS Code via the GitHub Pull Request extension.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.