Skip to content

Move git spec out of upstream, and fix issues around fetching many git commits #260749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Tyriar merged 5 commits into from
Aug 9, 2025
Merged

Move git spec out of upstream, and fix issues around fetching many git commits #260749

Tyriar merged 5 commits into from
Aug 9, 2025

Conversation

@Tyriar
Copy link
Member

@Tyriar Tyriar commented Aug 9, 2025 •
edited
Loading

Fixes #260748
Fixes #260160

  • Move git spec out of upstream, fix lint issues
  • Fix commit generator hash length
  • Restrict git commit history fetching to 1000 latest (>1s to < 100ms)
  • Prevent call stack limit issues due to spread operator vs .concat

@Tyriar Tyriar added this to the August 2025 milestone Aug 9, 2025
@Tyriar Tyriar self-assigned this Aug 9, 2025
@Tyriar Tyriar marked this pull request as draft August 9, 2025 11:47
@Tyriar Tyriar changed the title Fix commit generator hash length Move git spec out of upstream, and fix issues around fetching many git commits Aug 9, 2025
@Tyriar Tyriar marked this pull request as ready for review August 9, 2025 12:54
@Tyriar Tyriar enabled auto-merge August 9, 2025 12:56
@Tyriar Tyriar merged commit dafc6c5 into main Aug 9, 2025
18 checks passed
@Tyriar Tyriar deleted the tyriar/260748 branch August 9, 2025 15:33
@Tyriar Tyriar mentioned this pull request Aug 11, 2025
Closed
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Sep 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@TylerLeonhardt TylerLeonhardt TylerLeonhardt approved these changes

Assignees

@Tyriar Tyriar

Labels

None yet

Projects

None yet

Milestone

August 2025

Development

Successfully merging this pull request may close these issues.

Terminal suggest git commit generator doesn't handle hash length right Terminal suggest: git cherry-pick flags aren't supported

3 participants

@Tyriar @TylerLeonhardt