fix(mgt-react): migrates to modern React rendering#3449
fix(mgt-react): migrates to modern React rendering#3449tobi1220 wants to merge 2 commits intomicrosoftgraph:mainfrom
Conversation
|
Thank you for creating a Pull Request @@tobi1220. This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:
|
|
@microsoft-github-policy-service agree |
|
@Mnickii Did you by any chance happen to take a loot at this already? |
|
@tobi1220 thanks for this proposal. |
|
We can't take this change as it would break MGT functionality inside of SharePoint Framework solutions at present. Given that is our most common use case based on metrics we cannot have that level of impact at present. |
Closes #3412
PR Type
Bugfix
Description of the changes
The package
mgt-reactdoesn't work under React 19 because it uses React's deprecatedrender()(docs) function to render its components. From React 18 and onward , the functioncreateRoot()(docs) should be used. This PR applies the simple changes demonstrated in React's official migration guide. Thus, this will drop support for the deprecated React 17.PR checklist
yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)yarn setLicense)Other information