Add aria-label attributes to fluent-select elements in mgt-planner for accessibility compliance#3466
Open
Add aria-label attributes to fluent-select elements in mgt-planner for accessibility compliance#3466
Conversation
Author
|
@gavinbarron 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs. I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review. |
Contributor
|
Thank you for creating a Pull Request @@Copilot. This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:
|
…r accessibility Co-authored-by: gavinbarron <7122716+gavinbarron@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [MGTP - mgt-planner - docs]: Ensures every ARIA input field has an accessible name (mgt-planner,fluent-select[current-value="BaOG6AQ3nkWSrqiG9WM2PGUAA3IX"])
Add aria-label attributes to fluent-select elements in mgt-planner for accessibility compliance
Sep 8, 2025
|
📖 The updated storybook is available here |
Member
|
@vagpt please review this proposed fix, https://mgt.dev/next/pr/3466 , for #3371 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves an accessibility issue where fluent-select elements in the mgt-planner component were missing accessible names, causing screen readers and other assistive technologies to fail the "aria-input-field-name" accessibility requirement.
Problem
The accessibility testing tool identified that fluent-select elements at the following element path were not providing accessible names:
Solution
Added appropriate
aria-labelattributes to both fluent-select elements in therenderNewTask()method:Before:
After:
Changes Made
strings.ts: Added two new localized strings:
selectPlan: 'Select plan'- for the plan/group selectorselectBucket: 'Select bucket'- for the bucket/folder selectormgt-planner.ts: Added
aria-labelattributes to both fluent-select elements:aria-label="${this.strings.selectPlan}"aria-label="${this.strings.selectBucket}"Impact
This minimal change ensures that the mgt-planner component meets accessibility standards while preserving all existing functionality.
Fixes #3371.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
googlechromelabs.github.io/usr/local/bin/node install.mjs(dns block)https://storage.googleapis.com/chrome-for-testing-public/140.0.7339.80/linux64/chrome-linux64.zip/usr/local/bin/node install.mjs(http block)If you need me to access, download, or install something from one of these locations, you can either:
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.