Skip to content

✨ add support for workflow execution file send & workflow response loading #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sebastianMindee merged 19 commits into from
Nov 26, 2024
Merged

✨ add support for workflow execution file send & workflow response loading #204

sebastianMindee merged 19 commits into from
Nov 26, 2024

Conversation

@sebastianMindee
Copy link
Collaborator

@sebastianMindee sebastianMindee commented Nov 6, 2024 •
edited
Loading

Description

  • 📝 add documentation...?
  • ✨ add support for workflow endpoint
  • ♻️ add tests
  • ♻️ add explicit deserialize decorators in existing classes for consistency

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires a change to the official Guide documentation.

@sebastianMindee sebastianMindee marked this pull request as ready for review November 13, 2024 16:06
@sebastianMindee sebastianMindee changed the title ✨ add support for workflow enqueuing ✨ add support for workflow execution file send & workflow response loading Nov 14, 2024
ianardee
ianardee requested changes Nov 14, 2024
View reviewed changes
ianardee
ianardee requested changes Nov 18, 2024
View reviewed changes
Copy link
Collaborator

@ianardee ianardee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, just needs minor changes to the example

ianardee
ianardee approved these changes Nov 18, 2024
View reviewed changes
Copy link
Collaborator

@ianardee ianardee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but do not merge

@sebastianMindee sebastianMindee merged commit 4035a11 into main Nov 26, 2024
11 checks passed
@sebastianMindee sebastianMindee deleted the add-workflow-support branch November 26, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ianardee ianardee ianardee approved these changes

@jonathanMindee jonathanMindee Awaiting requested review from jonathanMindee

@thentgesMindee thentgesMindee Awaiting requested review from thentgesMindee

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sebastianMindee @thentgesMindee @ianardee