Skip to content

harmonize with other libs #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ianardee merged 4 commits into from
Jul 24, 2025
Merged

harmonize with other libs #363

ianardee merged 4 commits into from
Jul 24, 2025

Conversation

@ianardee
Copy link
Collaborator

@ianardee ianardee commented Jul 24, 2025 •
edited
Loading

Description

Harmonize names and such with other libs:

  • docFromXxx => sourceFromXxx
  • various vars/consts

Make it easier to import PageOptions.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires a change to the official Guide documentation.

@ianardee ianardee requested a review from sebastianMindee July 24, 2025 11:32
@ianardee ianardee marked this pull request as ready for review July 24, 2025 11:32
sebastianMindee
sebastianMindee requested changes Jul 24, 2025
View reviewed changes
@ianardee ianardee requested a review from sebastianMindee July 24, 2025 11:59
@ianardee ianardee merged commit 312dd21 into main Jul 24, 2025
38 of 42 checks passed
@ianardee ianardee deleted the doc-fixes branch July 24, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sebastianMindee sebastianMindee sebastianMindee approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ianardee @sebastianMindee