Skip to content

🐛 fix potential circular import errors #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sebastianMindee merged 7 commits into from
Nov 22, 2024
Merged

🐛 fix potential circular import errors #277

sebastianMindee merged 7 commits into from
Nov 22, 2024

Conversation

@sebastianMindee
Copy link
Collaborator

@sebastianMindee sebastianMindee commented Nov 22, 2024 •
edited by ianardee
Loading

Description

  • ♻️ make imports more specific
  • ♻️ refactor some of the code
  • ⚰️ remove support for International ID V1

Related Issue

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires a change to the official Guide documentation.

@sebastianMindee sebastianMindee added the bug Something isn't working label Nov 22, 2024
@sebastianMindee sebastianMindee self-assigned this Nov 22, 2024
@sebastianMindee sebastianMindee merged commit 1c61555 into main Nov 22, 2024
26 checks passed
@sebastianMindee sebastianMindee deleted the fix-circular-imports branch November 22, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ianardee ianardee ianardee approved these changes

Assignees

@sebastianMindee sebastianMindee

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sebastianMindee @ianardee