Skip to content

Conversation

@sebastianMindee
Copy link
Collaborator

@sebastianMindee sebastianMindee commented Nov 25, 2024

Description

♻️ also fix a bunch of improper imports

Related Issue

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires a change to the official Guide documentation.

@sebastianMindee sebastianMindee changed the title 🐛 fix broken install due to pyproject.toml migration 🐛 fix circular imports error on install Nov 25, 2024
Copy link
Contributor

@ianardee ianardee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad

@sebastianMindee
Copy link
Collaborator Author

Our bad, I still approved the PR [:

@sebastianMindee sebastianMindee merged commit 9146e43 into main Nov 25, 2024
26 checks passed
@sebastianMindee sebastianMindee deleted the update-imports branch November 25, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants