Skip to content

💥 version 4 #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sebastianMindee merged 17 commits into from
Feb 27, 2025
Merged

💥 version 4 #137

sebastianMindee merged 17 commits into from
Feb 27, 2025

Conversation

@sebastianMindee
Copy link
Collaborator

@sebastianMindee sebastianMindee commented Jan 21, 2025 •
edited
Loading

Description

  • 💥 drop support for ruby versions < 3.0
  • 💥 refactor error-handling
  • ✨ add proper logging
  • ♻️ refactor internal modules
  • ♻️ refactor test module
  • ✨ add typing support through RBS
  • ✨ add typing support through RBS for products
  • 📝 update documentation

Related Issue

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires a change to the official Guide documentation.

@sebastianMindee sebastianMindee force-pushed the develop/v4.0.0 branch 3 times, most recently from aa6b59d to aff4c8a Compare January 22, 2025 16:41
@sebastianMindee sebastianMindee force-pushed the develop/v4.0.0 branch 2 times, most recently from 75506c9 to 2356c28 Compare January 30, 2025 13:48
@sebastianMindee sebastianMindee marked this pull request as ready for review February 24, 2025 16:08
ianardee
ianardee requested changes Feb 25, 2025
View reviewed changes
Copy link
Collaborator

@ianardee ianardee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a comment in the sample code along the lines of:

#
# Install the Ruby client library from:
# https://rubygems.org/gems/mindee
#

or

#
# Install the Ruby client library by running:
# gem install mindee
#

@sebastianMindee sebastianMindee marked this pull request as draft February 26, 2025 15:00
sebastianMindee and others added 16 commits February 26, 2025 17:11
@sebastianMindee
💥 drop support for ruby versions < 3.0
c828ab6
@sebastianMindee
⬆️ bump dependencies, update lint
3e8388e
@sebastianMindee
💥 refactor error handling (#142)
8ee03e0
@sebastianMindee
💥 refactor extraction, image & pdf modules (#144)
a7ebf68
@sebastianMindee
💥 deprecate custom & generated, replace with universal (#143)
39beb42
@sebastianMindee
✨ add support for logging (#145)
865cc2a
@sebastianMindee
💥 allow page objects to be created even if they don't have an associa…
aa0879e 
…ted prediction (#146)
@sebastianMindee
💥 refactor internals to reduce clutter inside of files (#147)
2f41c88
@sebastianMindee
⚰️ remove support for US Driver License, EU Driver License & Proof of…
e1462af 
… Address (#148)
@sebastianMindee
💥 mutualise parse enqueue_and_parse calls (#150)
37268fe
@sebastianMindee
📝 fix missing yard documentation + micro-refacto (#151)
ed8e730
@sebastianMindee
✨ add support for typing through RBS (#152)
979e079
@sebastianMindee
♻️ temporarily remove support for ruby 3.4 until origamindee is fixed (…
e121c61 
…#153)
@sebastianMindee
♻️ add type signatures for products (#154)
cb0fd3c
@sebastianMindee
✨ add support for multiple fields (#155)
7edf4a6
@sebastianMindee
♻️ update UrlInputSource to URLInputSource (#160)
a7d2d25
@sebastianMindee sebastianMindee marked this pull request as ready for review February 26, 2025 16:21
ianardee
ianardee approved these changes Feb 27, 2025
View reviewed changes
@sebastianMindee sebastianMindee merged commit b634662 into main Feb 27, 2025
31 checks passed
@sebastianMindee sebastianMindee deleted the develop/v4.0.0 branch February 27, 2025 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ianardee ianardee ianardee approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sebastianMindee @ianardee