Skip to content

Conversation

@sebastianMindee
Copy link
Collaborator

Description

Use stricter pinning on the rubocop dependency version as they frequently add new cops to minor versions, which sometimes cause discrepencies between local & CI, or worse: PR CI & main branch CI.

Related Issue

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires a change to the official Guide documentation.

@sebastianMindee sebastianMindee requested a review from ianardee June 5, 2025 07:47
Copy link
Collaborator

@ianardee ianardee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not really a "hard" pin but looks good

@sebastianMindee sebastianMindee changed the title ♻️ hard-pin rubocop version to prevent unexpected CI failures ♻️ patch-pin rubocop version to prevent unexpected CI failures Jun 5, 2025
@sebastianMindee sebastianMindee merged commit d0bc809 into main Jun 5, 2025
31 checks passed
@sebastianMindee sebastianMindee deleted the pin-rubocop branch June 5, 2025 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants