Skip to content

Fix a crash when time's selecter set self to nil, cause to a zombie. #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Hydra2050 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix a crash when time's selecter set self to nil, cause to a zombie. #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions MSWeakTimer.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,16 +201,17 @@ - (void)timerFired
{
return;
}


MSWeakTimer *strongSelf = self;
// We're not worried about this warning because the selector we're calling doesn't return a +1 object.
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Warc-performSelector-leaks"
[self.target performSelector:self.selector withObject:self];
#pragma clang diagnostic pop

if (!self.repeats)
if (!strongSelf.repeats)
{
[self invalidate];
[strongSelf invalidate];
}
}

Expand Down