Skip to content

Conversation

@aab29
Copy link

@aab29 aab29 commented Oct 6, 2022

⚠️ I'm not 100% sure that these changes are safe. Achilles Desktop and Mobile still compile, and so far I haven't been able to get them to crash while playing games... but it's hard to be sure I didn't delete something important. ⚠️

I also wouldn't be surprised if this doesn't build on Android yet. We might need to update the CMakeLists or something. 🤖✋

MOAI is filled with lots of 3rd-party libraries and utilities that we aren't using at all. 🕸️ They probably seemed like good things to include in a game engine back in 2011 or so. 🏛️ These days there are better/more reliable ways to get most of this functionality. So I tried ripping out as much as I could. 🗿✂️ This is mostly low-hanging fruit. 🍍 I'm sure we could make more substantial improvements if we kept at it. 🗿🪓

Things I removed:

  • OpenSSL library 🚪
  • MOAIHashWriter ✍️
  • USHashWriter and subclasses 🇺🇸
  • luacrypto library 📉
  • luasql library 💿
  • luafilesystem library 💾
  • Definitions for AKUExtLoadLuasql, AKUExtLoadLuacrypto, AKUExtLoadLuacurl, and AKUExtLoadLuafilesystem 🗿
  • USXmlReader class 🕸️
  • expat XML parsing library 🛥️
  • chipmunk physics engine (We only use Box2D.) 🐿️

Aaron Barrett added 29 commits October 5, 2022 14:32
… `AKUExtLoadLuacurl`. Removed implementation of `AKUExtLoadLuasql` and the symbol `luaopen_luasql_sqlite3`.
… headers. Removed registration for Moai chipmunk integration classes.
@aab29 aab29 added the hold label Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants