Fixed parsing bug in the conversion to double #734
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
michelebastione
commented
Mar 11, 2025
michelebastione
commented
- Fixed problem where, after the latest commit, numeric strings were not being converted to double correctly due to a ToString call that lacked invariant localization (reference)
- Also added a missing Dispose call in MiniExcelDataReader, and a couple more superficial changes
- Fixed problem where, after the latest commit, numeric strings were not being converted to double correctly due to a ToString call that lacked invariant localization - Also added a missing Dispose call in MiniExcelDataReader, and a couple more superficial changes
shps951023
approved these changes
Mar 12, 2025
Member
|
@michelebastione 🐱🏍Merged, please feel free to feedback |
Contributor
Author
|
Thank you, just wanted to make sure someone else looked at it before merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.