Fixed cancellation token not working for some async methods, enhanced export methods by returning number of rows, added active tab functionality, tests and code cleanup #738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The methods Insert / InsertAsync now return the number of rows inserted into the worksheet, while SaveAs / SaveAsAsync return an int array representing the rows inserted into each worksheet - Added asserts in tests to that check for aferomentioned return values to be correct, plus a little bit of tiding said tests - Minor code cleanup (denesting branches, renaming variables, turning methods that don't change state of the object into static functions...)
- Fixed methods InsertAsync and SaveAsAsync not forwarding the cancellation token to the callees, preventing the actual cancellation of the processes from the outside - Added cancellation token support to a number of private and internal async methods, and increased the frequency of cancellation tokens checking whether they've been cancelled, in order to make the reach termination of the process as close as to when it's requested as possible
Adde property Active in classes SheetInfo and SheetRecord to indicate wheter the worksheet referenced represents the active tab
Contributor
Author
|
I apologize for the massive pull request, I hope it's not too much of an inconvenience to review. |
shps951023
approved these changes
Mar 16, 2025
Member
|
👍👍👍 Reviewed and merged, and I will release new version tomorrow night |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added cancellation token to async methods missing it
InsertAsyncandSaveAsAsyncnot forwarding the cancellation token to the callees, preventing the actual cancellation of the processe from the outsideMiniExcel.InsertAsync.Enhanced methods Insert, SaveAs and relative async versions
Added active tab functionality
Activein classesSheetInfoandSheetRecordto indicate wheter the worksheet referenced represents the active tab