Added new configuration options, exception throw for sheet name too long, bugfix of invalid cell index mistaken for valid #739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When trying to save an excel file with a sheet name of more than 31 charachters in length the program now throws an exception instead of writing a potentially broken document - Some test and code cleanup
- Added options TrimColumnNames and IgnoreEmptyRows to OpenXmlConfiguration. The first one allows properties to be mapped to column names even if they have whitespace or newline padding, the second one skips rows whose values are all null instead of instantiating a class with all values set to default (in the case of strong type mapping) - Added tests and samples for afermonetioned options - Refactored the ExcelOpenXmlSheetReader logic that reads the headers of an excel file and moved it to the CustomPropertyHelper class - General code and test cleanup
Restoring after reset
izanhzh
reviewed
Mar 19, 2025
izanhzh
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves No way to avoid empty rows after upgrade to 1.35.0 #697, Resolves Trim leading / trailing white space in column headers #719
Added options
TrimColumnNamesandIgnoreEmptyRowstoOpenXmlConfiguration. The first one allows properties to be mapped to column names even if they have whitespace or newline padding, the second one makes the datareader skip the rows whose values are all null, in place of previous behaviour when a class with all values set to default would be instantiated (in the case of strong type mapping)Resolves Saving with long Sheet names causes Excel to complain #693
When trying to use
SaveAsorInserton an Excel file with a sheet name of more than 31 charachters in length the program now throws an exceptionFixes Invalid Cell Range returns header row value #686
The program no longer mistakes invalid cell indexes as valid
Other
Refactored the
ExcelOpenXmlSheetReaderlogic that reads the headers of an excel file and moved it to theCustomPropertyHelperclass, added tests and samples, general code and test cleanupEdit
MiniExceltoExcelWriterFactoryas per @izanhzh suggestionDateTimenot being formatted correctly during export