Removing superfluous DateTimeHelper.FromOADate, added IASyncDispoable call to async writer, minor other fixes #740
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DateTimeHelper.FromOADatewas equivalent to the standardDateTime.FromOADatealready present in the framework. Although not being identical due to the latter using magic numbers instead of calculating some of the quantities, unwrapping those calculations showed a 1-1 match.usingstatements toawait usingwhen compiling for .NET5+ so thatDisposeAsyncis called instead ofDisposeEdit: Changed
NotImplementedExceptionassertions in some tests toNotSupportedExceptionafter the modification in the previous commit that also exchanged the two exception types