Skip to content

Conversation

@michelebastione
Copy link
Contributor

@michelebastione michelebastione commented Mar 23, 2025

  • Resolves Including first row in strong typed mapped Query from sheet with no header #542 by adding a parameter hasHeader to MiniExcel.Query<T> and MiniExcel.QueryAsync<T> that, when set to false, wil not treat the first row as a header but instead include its data in the result set. For the operation to be successful in absence of a header all the required properties have to be decorated with an ExcelColumnIndex attribute.
  • Added a test, a sample and some code cleanup

Added parameter hasHeader to Query<T> and QueryAsync<T> that, when set to false, wil not treat the first row as a header and include its data in the result set instead
@izanhzh
Copy link
Member

izanhzh commented Mar 24, 2025

Hi @michelebastione

Thank you for reaching out to me and trusting me with the review. However, I want to clarify that I am not one of the core maintainers/responsible persons for this project. I am concerned that I might not be the best person to provide a thorough and accurate review.

Therefore, I will remove myself from the review list and wait for the author to handle the review.

Best regards

@izanhzh izanhzh removed their request for review March 24, 2025 01:11
@michelebastione
Copy link
Contributor Author

michelebastione commented Mar 24, 2025

@izanhzh Thank you for the clarification, given you are one of the most active members I assumed you were part of the core team.

@shps951023 What do you think of this change?

@shps951023
Copy link
Member

@izanhzh Thank you for the clarification, given you are one of the most active members I assumed you were part of the core team.

@shps951023 What do you think of this change?

LGTM👍, but I don't have the requirements in my tasks.

@shps951023 shps951023 merged commit 0f8be6e into mini-software:master Mar 25, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Including first row in strong typed mapped Query from sheet with no header

3 participants