Skip to content

Conversation

@virzak
Copy link
Contributor

@virzak virzak commented Jun 30, 2025

There is no reason to target the library to .NET 9 since there is no code specific to that target (no #if NET9_0_OR_GREATER)

@virzak virzak marked this pull request as ready for review June 30, 2025 02:26
@michelebastione
Copy link
Contributor

Isn't it a bit early to start targeting .NET10? Granted it's not that we would use many target specific APIs but still, I personally would wait for the first release candidate before making the jump.

@virzak
Copy link
Contributor Author

virzak commented Jun 30, 2025

We might have to revert if dotnet decides to revert their Zip async implementation. Apart from that scenario I don't really see any downsides.

Our company is building a .NET 10 project already, so perhaps out of selfish reasons I'd like to have this library use .NET 10 APIs.

Having said that, there no problem if this gets merged after .NET code freeze in August.

BTW, you also expressed that we could remove net462, since it is already covered by .NET Standard 2.0, perhaps we can revisit this.

@michelebastione
Copy link
Contributor

I would wait, but I'm not against it. @shps951023 @izanhzh what do you think?

Also regarding the net462, I do think that it's become kind of pointless to keep it as an explicit target framework since it's fully compatible with netstandard2.0 and the dependencies would be resolved by nuget. But if some aspect is eluding me please let me know.

@izanhzh
Copy link
Member

izanhzh commented Jul 1, 2025

I strongly agree with removing specific target frameworks like .NET 462. In my opinion, we should only need to support the two standard targets: netstandard2.0 and netstandard2.1, unless there's a significant and compelling feature in a new .NET version that goes beyond what these two standards offer.

@michelebastione
Copy link
Contributor

I'd wager against including netstandard2.1, it's not supported by either .net framework nor UWP and Xamarin is deprecated so it doesn't make sense to add it in my opinion.

@virzak virzak changed the title Remove .NET 9 and add .NET 10 Remove .NET 9 and add .NET 10; remove .NET Framework 4.6.2 which is still being covered by .NET standard 2.0 Jul 1, 2025
@shps951023
Copy link
Member

I'm in favor of the change. 🙌

Below are the risks I think:

At the moment, many users in traditional production industries still rely heavily on .NET.
In these industries, .NET Framework is still the most commonly used platform, especially for technologies like WPF and WinForms .

I will do some testing to see what happens if we remove .NET Framework support and only target netstandard2.0.
Would that affect these legacy systems?

In theory, those systems could install additional runtime packages or SDKs to resolve compatibility issues.

@michelebastione
Copy link
Contributor

@shps951023 When you reference a netstandard package NuGet automatically pulls the compatible dependencies for the target framework being compiled, so there should be no problem with that.

Are you also in favor of the main point of adding .NET10 as a target framework?

@shps951023
Copy link
Member

shps951023 commented Jul 6, 2025

@michelebastione thanks, I agree with @virzak no #if NET9_0_OR_GREATER , we can upgrade to .net10🙌

@michelebastione michelebastione merged commit e80c3c2 into mini-software:master Jul 6, 2025
3 checks passed
@michelebastione michelebastione mentioned this pull request Sep 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants