fix for formulas not being replaced in templates

[ethanlin6]

This fixes issue #827 and #842 .

Previously, CleanXml was applied to the XML before formula processing, which removed the XML namespaces and caused XPath queries (such as SelectNodes("x:c", Ns)) to fail in ProcessFormulas. This resulted in formulas not being processed as expected.

[gemini-code-assist]

Summary of Changes

Hello @ethanlin6, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

I've addressed a critical bug where formulas were not being replaced in generated Excel files. The root cause was the premature removal of XML namespaces by a cleaning function, which interfered with the XPath queries used to locate and process formulas. My fix reorders the operations, ensuring that the XML structure retains its namespaces during formula processing, thereby allowing formulas to be correctly identified and replaced before the final output is generated.

Highlights

• Formula Processing Fix: I've identified and fixed an issue where formulas were not being processed correctly due to the CleanXml function being applied too early. This function was stripping XML namespaces, which in turn caused XPath queries used during formula processing to fail.
• XML Cleaning Timing Adjustment: The core change involves deferring the CleanXml operation. Instead of cleaning the XML content (innerXml and notFirstRowElement.InnerXml) upfront, I now apply CleanXml just before the final rowXml is written to the stream. This ensures that the XML structure, including namespaces, remains intact during the ProcessFormulas step, allowing XPath queries to function as intended.
• Issue Resolution: This change directly addresses and resolves issues #827 and #842, which reported the failure of formulas to be replaced in generated Excel files.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly addresses an issue where formulas were not being processed. The root cause was that CleanXml was called before ProcessFormulas, stripping necessary XML namespaces and causing XPath queries to fail. The fix astutely moves the CleanXml call to after ProcessFormulas has run, ensuring the XML is valid during processing and only cleaned just before being written to the output stream. The associated refactoring to remove now-unnecessary variables is also a welcome improvement. The changes are logical and effectively resolve the bug.

[michelebastione]

@ethanlin6 thank you for your contribution!