Skip to content

Fix for issue 876 on the maintenance branch #879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michelebastione merged 2 commits into from
Sep 13, 2025
Merged

Fix for issue 876 on the maintenance branch #879

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f26a73
Fixes issue 876 on the maintenance branch
michelebastione Sep 13, 2025
3c9f8af
Moved check for sheet name length after the GetSheetInfos call
michelebastione Sep 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/MiniExcel/OpenXml/ExcelOpenXmlSheetWriter.DefaultOpenXml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,9 @@ private IEnumerable<Tuple<SheetDto, object>> GetSheets()
{
sheetId++;
var sheetInfos = GetSheetInfos(sheet.Key);
if (sheetInfos.ExcelSheetName.Length > 31)
throw new ArgumentException("Sheet names must be less than 31 characters");

yield return Tuple.Create(sheetInfos.ToDto(sheetId), sheet.Value);
}

Expand Down Expand Up @@ -424,3 +427,4 @@ private string GetCellXfId(string styleIndex)
}
}
}

20 changes: 20 additions & 0 deletions tests/MiniExcelTests/MiniExcelIssueTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4699,4 +4699,24 @@ public void TestIssue869(string fileName, DateOnlyConversionMode mode, bool thro
}
}
}

[Fact]
public void TestIssue876()
{
var someTable = new[]
{
new { Name = "Jack", Age = 25 },
};

var sheets = new Dictionary<string, object>
{
["SomeVeryLongNameWithMoreThan31Characters"] = someTable
};

Assert.Throws<ArgumentException>(() =>
{
using var outputPath = AutoDeletingPath.Create();
MiniExcel.SaveAs(outputPath.ToString(), sheets);
});
}
Comment on lines +4704 to +4721
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Sep 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This is a good test for the IDictionary<string, object> case. To ensure complete coverage for the fix, it would be beneficial to add similar tests for DataSet and for the default sheet name scenario. This will help verify that the sheet name length validation is applied consistently across all ways of creating sheets.

}
Loading