Added custom exception for indexers being treated as properties durin…

[michelebastione]

Resolves #880

[gemini-code-assist]

Summary of Changes

Hello @michelebastione, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where types containing indexers could be incorrectly processed during serialization. It introduces a dedicated MiniExcelNotSerializableException to clearly communicate when a member cannot be serialized, specifically applying this validation to prevent the serialization of types with indexers. The change ensures more robust error handling and provides a clear indication to developers about non-serializable constructs.

Highlights

• New Custom Exception: Introduced MiniExcelNotSerializableException, a custom exception derived from InvalidOperationException, to specifically flag issues with non-serializable members. This exception includes the MemberInfo of the problematic member for better debugging.
• Indexer Serialization Prevention: Modified the MiniExcelProperty constructor to detect properties that are indexers. If an indexer is encountered during property processing, a MiniExcelNotSerializableException is now thrown, preventing the serialization of types containing indexers.
• Test Coverage for Indexers: Added a new unit test, TestIssue880_ShouldThrowNotSerializableException, which verifies that attempting to export a type containing an indexer correctly triggers the MiniExcelNotSerializableException.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a new MiniExcelNotSerializableException to provide a clear error when attempting to serialize types containing indexers, which are not supported. The implementation correctly identifies indexer properties and throws this specific exception. A corresponding unit test is added to verify the new behavior. My review includes a suggestion to enhance the new exception for better diagnostics by including the problematic member's name in the exception message, and a minor style fix to ensure file consistency.