Skip to content

Conversation

@michelebastione
Copy link
Contributor

- The mapping process will now try to apply the culture provided into the MiniExcelConfiguration when parsing doubles
- When the parsing of double types fails an MiniExcelInvalidCastException will be thrown instead of mapping the value to double.NaN
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @michelebastione, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the robustness and predictability of double type mapping within the MiniExcel library. By integrating culture-specific parsing from MiniExcelConfiguration and replacing implicit double.NaN assignments with explicit MiniExcelInvalidCastException for invalid inputs, it addresses two long-standing edge cases. These changes ensure more accurate data interpretation and provide clearer error signals, improving the overall reliability of Excel data processing.

Highlights

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces two important fixes for mapping double types. It now correctly uses the provided culture from MiniExcelConfiguration for parsing, and throws a MiniExcelInvalidCastException on parsing failure instead of silently mapping to double.NaN. The changes are well-tested with new and adjusted unit tests. I've suggested a small refactoring to the double parsing logic to make it more robust and clearer by explicitly handling culture conversions. Overall, this is a solid improvement.

@michelebastione michelebastione merged commit 0380907 into mini-software:master Oct 16, 2025
3 checks passed
@michelebastione michelebastione deleted the double-parsing-fixes branch October 16, 2025 21:56
michelebastione added a commit to michelebastione/MiniExcel that referenced this pull request Oct 16, 2025
michelebastione added a commit that referenced this pull request Oct 16, 2025
michelebastione added a commit to michelebastione/MiniExcel that referenced this pull request Oct 25, 2025
michelebastione added a commit to michelebastione/MiniExcel that referenced this pull request Oct 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Double 类型转换行为与其他类型不一致 Exponential number form has wrong result after reading

1 participant