-
-
Notifications
You must be signed in to change notification settings - Fork 399
Changing shared strings cache path from Guid based to TempPath based #897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing shared strings cache path from Guid based to TempPath based #897
Conversation
Also adding an option to OpenXmlConfiguration for manually overriding the path.
Summary of ChangesHello @michelebastione, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the handling of temporary files used for shared string caching in MiniExcel. Previously, these files were created in the application's working directory, which could lead to clutter or permission issues. The update changes the default behavior to utilize the system's designated temporary directory, providing a cleaner and more standard approach. Additionally, it introduces a new configuration option, SharedStringCachePath, giving developers explicit control over where these cache files are stored. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request is a good improvement, changing the shared string cache to use the system's temporary path by default and making it configurable. This avoids creating temporary files in the application's working directory. The implementation is mostly correct, but I've found a couple of issues in SharedStringsDiskCache that should be addressed. One is a logic error in determining the cache directory, which could lead to files being created in unexpected locations. The other is an off-by-one error in the enumerators. My review includes suggestions to fix these issues.
Mirrors PR mini-software#897 on the maintenance branch
Path.GetTempPathby default instead of creating temporary files in the program's working directory