Skip to content

Conversation

@michelebastione
Copy link
Contributor

  • Adding net10.0 to the target frameworks
  • Updating packages, tests and workflows where necessary
  • Migrating the solution file to the new .slnx format

- Updating target frameworks, packages, tests and workflows.
- Migrating the solution file to new .slnx format.
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @michelebastione, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request undertakes a significant refactoring effort to prepare the project for the upcoming .NET 10 and Visual Studio 18 releases. The core changes involve updating the project's target frameworks to include net10.0, migrating the solution file to a modern XML-based format, and ensuring all dependencies are up-to-date by updating various NuGet packages. Additionally, test code has been slightly refined for better clarity.

Highlights

  • .NET 10 Support: Added net10.0 to the target frameworks for both the main library (MiniExcelLibs.csproj) and the benchmarks project (MiniExcel.Benchmarks.csproj), ensuring compatibility with the latest .NET version.
  • Solution File Migration: Migrated the Visual Studio solution file from the traditional .sln format to the newer XML-based .slnx format, improving readability and potentially simplifying tooling.
  • Package Updates: Updated several NuGet packages across the solution, including NPOI, Microsoft.SourceLink.GitHub, Microsoft.Bcl.AsyncInterfaces, Microsoft.NET.Test.Sdk, xunit, and xunit.runner.visualstudio, to their latest stable versions.
  • Test Assertion Refactoring: Refactored test assertions in various test files, replacing Assert.Equal(null, ...) with the more idiomatic and clearer Assert.Null(...) for null value checks.
Ignored Files
  • Ignored by pattern: .github/workflows/** (3)
    • .github/workflows/benchmark.yml
    • .github/workflows/codeql-analysis.yml
    • .github/workflows/dotnet.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively prepares the project for .NET 10 and Visual Studio 18 by updating target frameworks, migrating to the modern .slnx solution format, and refreshing package dependencies. The refactoring of tests to use Assert.Null is a welcome improvement for code clarity and consistency. I have one suggestion to enhance the test coverage across all supported frameworks.

Signed-off-by: Michele Bastione <michele.bastione@gmail.com>
Signed-off-by: Michele Bastione <michele.bastione@gmail.com>
@michelebastione michelebastione merged commit d590bb5 into mini-software:v1.x-maintenance Nov 14, 2025
3 checks passed
@michelebastione michelebastione deleted the net10-refactoring-maintenance branch November 14, 2025 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant