-
-
Notifications
You must be signed in to change notification settings - Fork 399
.NET 10 Refactoring #900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.NET 10 Refactoring #900
Conversation
Updating packages, tests and workflows where necessary
- Moved test data from samples to tests/data and updated paths in test files - Moved MiniExcel.Tests.AspNetCore from tests to samples and renamed it to MiniExcel.Samples.AspNetCore - Removed AspNetMvc and WebForms samples
- Added a new solution file for the samples - Converted MiniExcel.Samples.AspNetCore project to a minimal apis project and renamed it to MiniExcel.Samples.MinimalApis - Added a MiniExcel.Samples.Blazor sample project - Added a MiniExcel.Samples.FileBasedApp sample file - Unrelated minor changes: moved icon.png from src folder to docs folder, moved some editorconfig lines to a more specific editorconfig in the src folder, removed redundant System.IO.Compression package reference from Directory.Packages.props
Summary of ChangesHello @michelebastione, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly modernizes the project by upgrading its target framework to .NET 10 and updating numerous dependencies. It also revamps the sample applications, replacing outdated ASP.NET MVC and WebForms examples with new Blazor and Minimal APIs projects, and reorganizes test data for better maintainability. These changes aim to keep the project current with the latest .NET ecosystem and improve its overall structure. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request is a significant modernization effort, introducing .NET 10 support, updating dependencies, and revamping the sample projects. The changes are well-organized, and the file restructuring improves the project's clarity. I've identified a couple of bugs in the new Blazor and Minimal API samples that should be addressed. My feedback includes a fix for a data binding issue and a correction for an incorrect attribute usage in an endpoint. Overall, this is a valuable update for the project.
Modernizing projects
.net10.0target framework to projectsMiniExcel.Tests.AspNetCoreproject to a minimal apis project, renamed it toMiniExcel.Samples.MinimalApisand moved it to the samples folderMiniExcel.SamplesMiniExcel.Samples.Blazorproject as a simple blazor sampleMiniExcel.Samples.FileBasedAppUnrelated changes
System.IO.Compressionpackage reference from Directory.Packages.propsNOTE: Even though a lot of files seem to contains changes, 95% of these are just for having moved folders to the test data