Skip to content

Conversation

@michelebastione
Copy link
Contributor

@michelebastione michelebastione commented Nov 16, 2025

Modernizing projects

  • Added .net10.0 target framework to projects
  • Updated packages, tests and workflows where necessary
  • Moved test data from samples to tests/data and updated paths in the test files
  • Converted MiniExcel.Tests.AspNetCore project to a minimal apis project, renamed it to MiniExcel.Samples.MinimalApis and moved it to the samples folder
  • Removed old AspNetMvc and WebForms samples
  • Added new solution MiniExcel.Samples
  • Added a MiniExcel.Samples.Blazor project as a simple blazor sample
  • Added a file based app sample file in MiniExcel.Samples.FileBasedApp

Unrelated changes

  • Moved some editorconfig properties to a more specific editorconfig in the src folder
  • Removed redundant System.IO.Compression package reference from Directory.Packages.props
  • Other minor style changes

NOTE: Even though a lot of files seem to contains changes, 95% of these are just for having moved folders to the test data

Updating packages, tests and workflows where necessary
- Moved test data from samples to tests/data and updated paths in test files
- Moved MiniExcel.Tests.AspNetCore from tests to samples and renamed it to MiniExcel.Samples.AspNetCore
- Removed AspNetMvc and WebForms samples
- Added a new solution file for the samples
- Converted MiniExcel.Samples.AspNetCore project to a minimal apis project and renamed it to MiniExcel.Samples.MinimalApis
- Added a MiniExcel.Samples.Blazor sample project
- Added a MiniExcel.Samples.FileBasedApp sample file
- Unrelated minor changes: moved icon.png from src folder to docs folder, moved some editorconfig lines to a more specific editorconfig in the src folder, removed redundant System.IO.Compression package reference from Directory.Packages.props
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @michelebastione, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly modernizes the project by upgrading its target framework to .NET 10 and updating numerous dependencies. It also revamps the sample applications, replacing outdated ASP.NET MVC and WebForms examples with new Blazor and Minimal APIs projects, and reorganizes test data for better maintainability. These changes aim to keep the project current with the latest .NET ecosystem and improve its overall structure.

Highlights

  • .NET 10 Upgrade: The project has been updated to target .NET 10.0, ensuring compatibility with the latest framework features and performance improvements.
  • Dependency Updates: Various NuGet packages, including BenchmarkDotNet, NPOI, Zomp.SyncMethodGenerator, and Microsoft.SourceLink.GitHub, have been updated to their latest versions.
  • Sample Project Restructuring: Old ASP.NET MVC and WebForms sample projects have been removed. A new MiniExcel.Samples solution has been introduced, containing new Blazor and Minimal APIs sample projects, demonstrating modern web development integration.
  • Test Data Relocation: All test data previously located in the samples folder has been moved to a dedicated tests/data directory, centralizing test resources and improving project organization.
  • Code Style and Configuration Enhancements: EditorConfig files have been refined, with specific code analysis diagnostics moved to a more granular src/.editorconfig and the adoption of file-scoped namespaces.
Ignored Files
  • Ignored by pattern: .github/workflows/** (2)
    • .github/workflows/benchmark.yml
    • .github/workflows/codeql-analysis.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is a significant modernization effort, introducing .NET 10 support, updating dependencies, and revamping the sample projects. The changes are well-organized, and the file restructuring improves the project's clarity. I've identified a couple of bugs in the new Blazor and Minimal API samples that should be addressed. My feedback includes a fix for a data binding issue and a correction for an incorrect attribute usage in an endpoint. Overall, this is a valuable update for the project.

@michelebastione michelebastione marked this pull request as draft November 16, 2025 15:18
@michelebastione michelebastione marked this pull request as ready for review November 16, 2025 16:41
@michelebastione michelebastione merged commit 045c28c into mini-software:master Nov 16, 2025
3 checks passed
@michelebastione michelebastione deleted the net10-refactoring branch November 16, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant